[PLAT-11587] Update Mac Arm64 version of node#2
Conversation
| { | ||
| "id": "node", | ||
| "version": "20.18.0", | ||
| "arch": "arm64", |
There was a problem hiding this comment.
Instead of renaming everything from aarch64 to arm64, could this line have been renamed from arm64 to aarch64 instead? (so that no other changes but adding this one JSON entry here, and below for the SDK, would be needed?)
There was a problem hiding this comment.
Yes, probably, I just thought it might be a good opportunity to consolidate the references since we use both in different places
There was a problem hiding this comment.
I cherry-picked the change from upstream emscripten by the way: see here
There was a problem hiding this comment.
it might be a good opportunity to consolidate
The consolidation would be best to happen when we update to upstream code. Ideally we would just add the minimum amount of code that would be specific to mac arm 64 into our downstream fork.
But in the interest of saving time, let's go with this form.
Description
This PR is for updating the version of node we're using for building emscripten for Mac Arm64. This change was needed because the Build Emsdk Mac (M1 Arm64) job was failing with the error that the version of node we were using wasn't compatible with our CPU. This is because Mac M1 is only supported by node versions 16 or higher. This PR updates the node version being used by the job to be 20.18.0, which is the most up to date node version being used by the upstream emsdk repository at the time of writing this PR. Also included in this PR is this change which was cherry-picked from the upstream emsdk repository. This was necessary to add because previously we had references to "arm64" and "aarch64" which represented the same architecture, but conflicted with each other when they shouldn't because we were using two separate names for the same thing.
Testing